qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Give an error when using -icount option with kv


From: Cao,Bing Bu
Subject: Re: [Qemu-devel] [PATCH] Give an error when using -icount option with kvm accelerator
Date: Mon, 14 Nov 2011 14:17:32 +0800
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111104 Red Hat/3.1.16-2.el6_1 Thunderbird/3.1.16

On 11/11/2011 03:09 PM, Cao,Bing Bu wrote:
With -icount, the vm_clock is updated with help from TCG (it counts 
instructions at 2^ICOUNT ns/instructions).  With KVM, the instruction count is 
not available so KVM cannot provide this help.

Signed-off-by: Cao,Bing Bu<address@hidden>
---
  vl.c |    8 ++++++--
  1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/vl.c b/vl.c
index f169aac..d2857a4 100644
--- a/vl.c
+++ b/vl.c
@@ -3226,8 +3226,12 @@ int main(int argc, char **argv, char **envp)
          fprintf(stderr, "could not initialize alarm timer\n");
          exit(1);
      }
-    configure_icount(icount_option);
-
+    if (!kvm_enabled()) {
+        configure_icount(icount_option);
+    } else {
+        fprintf(stderr, "-icount option only allowed without kvm 
accelerator\n");
+        exit(1);
+    }
      if (net_init_clients()<  0) {
          exit(1);
      }
This patch has a obvious bug,so bad!

Sorry for that, and the new patch has been added by Max Filippov.

+    if (icount_option && (kvm_enabled() || xen_enabled())) {
+        fprintf(stderr, "-icount is not allowed with kvm or xen\n");
+        exit(1);
+    }

    configure_icount(icount_option);

--
Best Regards,
Cao,Bing Bu




reply via email to

[Prev in Thread] Current Thread [Next in Thread]