Re: [Qemu-devel] [PATCH 1/7] migrate: add migration blockers

[Kevin Wolf]

Am 12.11.2011 16:56, schrieb Anthony Liguori:
> This lets different subsystems register an Error that is thrown whenever
> migration is attempted.  This works nicely because it gracefully supports
> things like hotplug.
> 
> Right now, if multiple errors are registered, only one of them is reported.
> I expect that for 1.1, we'll extend query-migrate to return all of the reasons
> why migration is disabled at any given point in time.
> 
> Signed-off-by: Anthony Liguori <address@hidden>
> Signed-off-by: Anthony Liguori <address@hidden>
> ---
>  migration.c |   18 ++++++++++++++++++
>  migration.h |   15 +++++++++++++++
>  2 files changed, 33 insertions(+), 0 deletions(-)
> 
> diff --git a/migration.c b/migration.c
> index 41c3c24..6764d3a 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -398,6 +398,18 @@ static MigrationState *migrate_init(Monitor *mon, int 
> detach, int blk, int inc)
>      return s;
>  }
>  
> +static GSList *migration_blockers;

Any reason not to use qemu-queue.h? It's used everywhere else and being
consistent is usually a good thing. If you want to switch to the glib
functions as the standard for whatever reason, shouldn't we convert
everything at once?

Kevin