Re: [Qemu-devel] [TestDays] s390x emulation error

[Andreas Färber]

Am 13.11.2011 09:48, schrieb Paolo Bonzini:
> On 11/12/2011 11:08 AM, Andreas Färber wrote:
>> I found that the following main-loop change works around it for s390x
>> and rl78 but breaks x86_64 SeaBIOS boot. Paolo, any ideas?
>>
>> diff --git a/main-loop.c b/main-loop.c
>> index 60e9748..2ab5023 100644
>> --- a/main-loop.c
>> +++ b/main-loop.c
>> @@ -460,7 +460,7 @@ int main_loop_wait(int nonblocking)
>>       }
>>
>>       glib_select_poll(&rfds,&wfds,&xfds, (ret<  0));
>> -    qemu_iohandler_poll(&rfds,&wfds,&xfds, ret);
>> +    qemu_iohandler_poll(&rfds,&wfds,&xfds, (ret<  0));
>>   #ifdef CONFIG_SLIRP
>>       slirp_select_poll(&rfds,&wfds,&xfds, (ret<  0));
>>   #endif
> 
> No, this is definitely wrong. :)  It will break all iohandlers.

Yeah, I noticed that myself in the part you had snipped above.
Question is, why are some use cases broken "iff" used right. :)
Any suggestions where/how to debug this?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg