[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] block: Use bdrv functions to replace file operation
From: |
Li Zhi Hui |
Subject: |
[Qemu-devel] [PATCH] block: Use bdrv functions to replace file operation in qcow.c |
Date: |
Fri, 18 Nov 2011 17:12:53 +0800 |
Since common file operation functions lack of error detection and use much more
I/O syscalls,
so change them to bdrv series functions and reduce I/O request.
Signed-off-by: Li Zhi Hui <address@hidden>
---
block/qcow.c | 42 +++++++++++++++++++++++-------------------
1 files changed, 23 insertions(+), 19 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index adecee0..089e79e 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -612,13 +612,14 @@ static void qcow_close(BlockDriverState *bs)
static int qcow_create(const char *filename, QEMUOptionParameter *options)
{
- int fd, header_size, backing_filename_len, l1_size, i, shift;
+ int header_size, backing_filename_len, l1_size, shift;
QCowHeader header;
- uint64_t tmp;
+ uint8_t *tmp;
int64_t total_size = 0;
const char *backing_file = NULL;
int flags = 0;
int ret;
+ BlockDriverState *qcow_bs;
/* Read out options */
while (options && options->name) {
@@ -632,9 +633,16 @@ static int qcow_create(const char *filename,
QEMUOptionParameter *options)
options++;
}
- fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, 0644);
- if (fd < 0)
- return -errno;
+ ret = bdrv_create_file(filename, options);
+ if (ret < 0) {
+ return ret;
+ }
+
+ ret = bdrv_file_open(&qcow_bs, filename, BDRV_O_RDWR);
+ if (ret < 0) {
+ return ret;
+ }
+
memset(&header, 0, sizeof(header));
header.magic = cpu_to_be32(QCOW_MAGIC);
header.version = cpu_to_be32(QCOW_VERSION);
@@ -670,33 +678,29 @@ static int qcow_create(const char *filename,
QEMUOptionParameter *options)
}
/* write all the data */
- ret = qemu_write_full(fd, &header, sizeof(header));
+ ret = bdrv_pwrite(qcow_bs, 0, &header, sizeof(header));
if (ret != sizeof(header)) {
- ret = -errno;
goto exit;
}
if (backing_file) {
- ret = qemu_write_full(fd, backing_file, backing_filename_len);
+ ret = bdrv_pwrite(qcow_bs, sizeof(header),
+ backing_file, backing_filename_len);
if (ret != backing_filename_len) {
- ret = -errno;
goto exit;
}
-
}
- lseek(fd, header_size, SEEK_SET);
- tmp = 0;
- for(i = 0;i < l1_size; i++) {
- ret = qemu_write_full(fd, &tmp, sizeof(tmp));
- if (ret != sizeof(tmp)) {
- ret = -errno;
- goto exit;
- }
+
+ tmp = g_malloc0(sizeof(uint64_t)*l1_size);
+ ret = bdrv_pwrite(qcow_bs, header_size, tmp, sizeof(uint64_t)*l1_size);
+ g_free(tmp);
+ if (ret != sizeof(uint64_t)*l1_size) {
+ goto exit;
}
ret = 0;
exit:
- close(fd);
+ bdrv_delete(qcow_bs);
return ret;
}
--
1.7.4.1
- [Qemu-devel] [PATCH] block: Use bdrv functions to replace file operation in qcow.c,
Li Zhi Hui <=
- Re: [Qemu-devel] [PATCH] block: Use bdrv functions to replace file operation in qcow.c, Stefan Hajnoczi, 2011/11/18
- Re: [Qemu-devel] [PATCH] block: Use bdrv functions to replace file operation in qcow.c, Paolo Bonzini, 2011/11/18
- Re: [Qemu-devel] [PATCH] block: Use bdrv functions to replace file operation in qcow.c, Stefan Hajnoczi, 2011/11/18
- Re: [Qemu-devel] [PATCH] block: Use bdrv functions to replace file operation in qcow.c, Kevin Wolf, 2011/11/21
- Re: [Qemu-devel] [PATCH] block: Use bdrv functions to replace file operation in qcow.c, Stefan Hajnoczi, 2011/11/21
- Re: [Qemu-devel] [PATCH] block: Use bdrv functions to replace file operation in qcow.c, Kevin Wolf, 2011/11/21
- Re: [Qemu-devel] [PATCH] block: Use bdrv functions to replace file operation in qcow.c, Paolo Bonzini, 2011/11/21