Re: [Qemu-devel] [PATCH 2/8] qcow2: Return real error code in qcow2_write_snapshots

[Stefan Hajnoczi]

On Thu, Nov 17, 2011 at 3:13 PM, Kevin Wolf <address@hidden> wrote:
> -    /* update the various header fields */
> +    /*
> +     * Update the header to point to the new snapshot table. This requires 
> the
> +     * new table and its refcounts to be stable on disk.
> +     *
> +     * FIXME This should be done with a single write

The nb_snapshots and snapshots_offset writes can be easily combined
since the fields are adjacent in QcowHeader.  I think it's worth
changing the code to do it in this patch series instead of leaving a
FIXME comment.

Stefan