[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] slirp: Clean up net_slirp_hostfwd_remove()'s us
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] slirp: Clean up net_slirp_hostfwd_remove()'s use of get_str_sep() |
|
Date: |
Fri, 18 Nov 2011 13:53:31 +0000 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Nov 16, 2011 at 03:45:59PM +0100, Markus Armbruster wrote:
> get_str_sep() can fail, but net_slirp_hostfwd_remove() doesn't check.
> Works, because it initializes buf[] to "", which get_str_sep() doesn't
> touch when it fails. Coverity doesn't like it, and neither do I.
>
> Change it to work exactly like slirp_hostfwd().
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> net/slirp.c | 9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
Thanks, applied to the trivial patches -next tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches-next
Stefan