[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] [SPARC] Improve "ta 0" shutdown
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH] [SPARC] Improve "ta 0" shutdown |
Date: |
Sat, 19 Nov 2011 14:01:23 +0000 |
On Mon, Nov 14, 2011 at 09:37, Fabien Chouteau <address@hidden> wrote:
> On 13/11/2011 10:43, Blue Swirl wrote:
>> On Thu, Nov 3, 2011 at 15:17, Fabien Chouteau <address@hidden> wrote:
>>> This patch replace the previous implementation with this simplified and
>>> more complete version (no shutdown when psret == 1).
>>
>> In order to get in 1.0, the change should be limited to adding only a
>> psret check to current helper_shutdown(). This way it should be also
>> possible to retain the CPU feature check in translation time instead
>> of pushing it to do_interrupt path, so it should be a better for
>> performance anyway.
>>
>
> The purpose of this feature is to know when we get to this error state
> (trap when interrupts disabled), if we abort with an error message or
> just shutdown the emulator. In any case it's the end of the emulation,
> it happens only once, so performance is not important here.
Right, so I applied this as is, thanks.
> For 1.0, I can do another intermediate patch.
>
> --
> Fabien Chouteau
>