[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/7] ehci: add assert
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 6/7] ehci: add assert |
Date: |
Mon, 21 Nov 2011 17:15:47 +0100 |
Coverity thinks q could be NULL there and warns.
I believe it can't be NULL there.
Add assert to prove it.
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/usb-ehci.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c
index cdd5aae..3eea94d 100644
--- a/hw/usb-ehci.c
+++ b/hw/usb-ehci.c
@@ -2046,6 +2046,7 @@ static void ehci_advance_state(EHCIState *ehci,
break;
case EST_WRITEBACK:
+ assert(q != NULL);
again = ehci_state_writeback(q, async);
break;
--
1.7.1
- [Qemu-devel] [PULL v2 1.0] usb patch queue, Gerd Hoffmann, 2011/11/21
- [Qemu-devel] [PATCH 6/7] ehci: add assert,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 5/7] usb-storage: don't try to send the status early., Gerd Hoffmann, 2011/11/21
- [Qemu-devel] [PATCH 2/7] usb-storage: fill status in complete callback., Gerd Hoffmann, 2011/11/21
- [Qemu-devel] [PATCH 4/7] usb-storage: drop result from device state., Gerd Hoffmann, 2011/11/21
- [Qemu-devel] [PATCH 1/7] usb-storage: move status debug message to usb_msd_send_status., Gerd Hoffmann, 2011/11/21
- [Qemu-devel] [PATCH 3/7] usb-storage: drop tag from device state., Gerd Hoffmann, 2011/11/21
- [Qemu-devel] [PATCH 7/7] usb-linux: fix /proc/bus/usb/devices scan, Gerd Hoffmann, 2011/11/21
- Re: [Qemu-devel] [PULL v2 1.0] usb patch queue, Anthony Liguori, 2011/11/21