[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] imx.31 and KZM board support
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH] imx.31 and KZM board support |
Date: |
Tue, 22 Nov 2011 12:06:01 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) |
Peter Chubb <address@hidden> wrote:
> Hi Peter,
> Please find appended a patch containing initial support for the
> FreeScale i.MX31 and the KZM Arm11 evaluation board.
>
> The implementation was originally written by Hans Jang and Adam
> Clench of OK-Labs; I've updated it to the current qdev and memory
> region paradigms and implemented enough extra that Linux will boot
> on the patched QEMU using a ram disk.
>
> The i.MX 31 Serial controller is found in most of the i.MX SoCs;
> the AVIC and timer implementations can also be shared, albeit with
> fewer chips.
>
> Signed-off-by: Peter Chubb <address@hidden>
> Signed-off-by: Hans Jang <address@hidden>
> Signed-off-by: Adam Clench <address@hidden>
> +static const VMStateDescription vmstate_imxg_timer = {
> + .name = "imxg-timer",
> + .version_id = 1,
> + .minimum_version_id = 1,
> + .minimum_version_id_old = 1,
> + .fields = (VMStateField[]) {
> + VMSTATE_UINT32(cr, imxg_timer_state),
> + VMSTATE_UINT32(sr, imxg_timer_state),
> + VMSTATE_UINT32(ir, imxg_timer_state),
> + VMSTATE_UINT32(cnt, imxg_timer_state),
> + VMSTATE_UINT32(ocr1, imxg_timer_state),
> + VMSTATE_TIMER(timer, imxg_timer_state),
> + VMSTATE_END_OF_LIST()
> + }
> +};
This is not used. Shouldn't a call like this be needed?
> +static int imxg_timer_init(SysBusDevice *dev)
> +{
> + imxg_timer_state *s = FROM_SYSBUS(imxg_timer_state, dev);
> +
> + sysbus_init_irq(dev, &s->irq);
> + memory_region_init_io(&s->iomem, &imxg_timer_ops,
> + s, "imxg-timer",
> + 0x00001000);
> + sysbus_init_mmio_region(dev, &s->iomem);
> +
> + s->timer = qemu_new_timer_ns(vm_clock, imxg_timer_timeout, s);
> + s->cr = 0;
> + s->ir = 0;
> + s->pr = 0;
> + s->ocr1 = 0;
> + imxg_timer_update_count(s);
vmstate_register(&dev->qdev, -1, &vmstate_imxg_timer, s);
???
I only looked at the vmstate bits, though.
Later, Juan.
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, (continued)
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, Peter Chubb, 2011/11/21
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, Peter Maydell, 2011/11/24
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, Andreas Färber, 2011/11/24
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, Peter Maydell, 2011/11/24
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, Andreas Färber, 2011/11/24
- Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board, Peter Maydell, 2011/11/24
- Re: [Qemu-devel] [PATCH V2 0/4] imx.31 and KZM board support, Peter Chubb, 2011/11/22
- Re: [Qemu-devel] [PATCH V2 0/4] imx.31 and KZM board support, Andreas Färber, 2011/11/24
- Re: [Qemu-devel] [PATCH V2 0/4] imx.31 and KZM board support, Peter Chubb, 2011/11/26
- Re: [Qemu-devel] [PATCH V2 0/4] imx.31 and KZM board support, Peter Maydell, 2011/11/26
Re: [Qemu-devel] [PATCH] imx.31 and KZM board support,
Juan Quintela <=