qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 0/9] qcow2: Fix error paths for internal snap


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v2 0/9] qcow2: Fix error paths for internal snapshots
Date: Tue, 22 Nov 2011 14:21:04 +0000

On Tue, Nov 22, 2011 at 2:12 PM, Kevin Wolf <address@hidden> wrote:
> Am 21.11.2011 17:58, schrieb Stefan Hajnoczi:
>> On Fri, Nov 18, 2011 at 6:28 PM, Kevin Wolf <address@hidden> wrote:
>>> Kevin Wolf (9):
>>>  qcow2: Return real error code in qcow2_read_snapshots
>>>  qcow2: Return real error code in qcow2_write_snapshots
>>>  qcow2: Update snapshot table information at once
>>>  qcow2: Cleanups and memleak fix in qcow2_snapshot_create
>>>  qcow2: Rework qcow2_snapshot_create error handling
>>>  qcow2: Return real error in qcow2_snapshot_goto
>>>  qcow2: Fix order of refcount updates in qcow2_snapshot_goto
>>>  qcow2: Fix order in qcow2_snapshot_delete
>>>  qcow2: Fix error path in qcow2_snapshot_load_tmp
>>>
>>>  block/qcow2-refcount.c |    7 +-
>>>  block/qcow2-snapshot.c |  330 
>>> +++++++++++++++++++++++++++++++++++-------------
>>>  block/qcow2.c          |    5 +-
>>>  3 files changed, 248 insertions(+), 94 deletions(-)
>>
>> Reviewed-by: Stefan Hajnoczi <address@hidden>
>
> Applied to the block branch (for 1.1)
>
> Do you think any of the patches could/should be merged for 1.0?

I would leave them and continue testing them over the 1.1 release
cycle.  No users have reported these issues AFAIK and they are not
regressions from the last QEMU release.  It's getting late in the 1.0
cycle and changing image format code is always delicate because of
what happens if something goes wrong.

My 2 cents.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]