Re: [Qemu-devel] [PATCH v3 07/11] bonito: convert north bridge register mapping to memory API

[Peter Maydell]

2011/11/23 Benoît Canet <address@hidden>:
> It would work using memory_region_add_subregion() and get_system_memory()
> but Avi previously noticed me that using get_system_memory() in devices
> is wrong because it goes against one of the goals of the memory API :
> avoiding global knowledge.

Yes. It's a bit difficult to tell without hardware docs for
this chip, but I suspect that at least some of these memory
regions should actually be registered as part of the
init of the "Bonito-pcihost" sysbus device and then mapped
by bonito_init(). But I don't know enough about PCI or the
Bonito to know just how much of bonito_initfn() ought to move
into bonito_pcihost_initfn().

-- PMM