qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] configure: avoid screening of --{en, dis}able-u


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] configure: avoid screening of --{en, dis}able-usb-redir options
Date: Thu, 24 Nov 2011 09:25:44 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1

On 11/23/2011 11:22 PM, Peter Maydell wrote:
I just said this in the other thread, but to repeat it in the
right place: I think we should expand out the case statement
to explicitly list the --thingydir options it is supposed to
be matching, and drop the wildcard: as this bug demonstrates
it's rather easy to accidentally shoot yourself in the foot
with it.

In fact, what cases is this supposed to be matching? All
the documented --thingydir options are handled explicitly
earlier in the case statement.

Paolo, you added this case in commit 6bde81cb0, but the
commit message doesn't give any rationale; what's it for?

There were some --*dir that are supported by Autoconf and not by QEMU configure. The aim was to let QEMU packagers use the rpm (or similar) macro that overrides directories for their distribution.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]