Re: [Qemu-devel] [PATCH v2 0/8] [RFC] vmstate: Add copyrights for all cpus

[Andreas Färber]

Hi Juan,

Am 23.11.2011 16:44, schrieb Juan Quintela:
> [ Resnd this time also ading fabrice address, sorry ]
> 
> v2:
> - split patches by file, make easier to add "acked-by" notices.
> - cc'd fabrice
> - everybody (except for Thiemo for ovbious reasons) answered.
> - move ppc/sparc/i386 to BSD like license from vl.c at Blue
>   suggestion. 
> 
> - move all other licenses to GPL v2 or later (notice that I had forget
>   the later part on the 1st submission).  Notice this change for the
>   people that acked previous version.
> 
> Any other comments?

I did have another comment regarding the "Based on" part that you
haven't responded to yet.

Andreas

> 
> v1:
> 
> This patch adds copyrights to all the machine description files for
> all architectures supported. (this is done on top of my vmstate-cpus
> series patches) The problem?
> 
> - What should we put as "copyirght" owners.
> 
> Althought I modified almost every line of the files, mostly of the
> changes are a conversion, so claiming myself as the only "copyright"
> owner sounds at least pretentious, and more than probably false.
> 
> I tried to "dig" into the git logs and tried to came with "whoever"
> commit the initial cpu_save/load foar each architecture.  I have put
> them as:
> 
>  * Based on qemu-file support done by:
>  *   Richard Henderson <address@hidden>
> 
> But I would preffer that the persons involved state what copyright
> notice they want, name, address, year(s), etc.  (Some architectures
> already have a propper copyright notice, I didn't touch them), and
> others had an empty file (I put mine there on the previosu series).
> 
> Several of the logs are from the svn days, and then I don't know if
> the person was the committer, or the author.  If anyone contributed
> to the functionality and want to add its copyright, please told me.
> 
> To make things more complicated, when machine.c files were split from
> vl.c, they didn't carry any copyright notice at all, should we copy
> back everything from vl.c?
> 
> To make things more complicated, it looks like Thiemo Seufer did the
> original mips support, and he passed away.  So he can't obviously
> comment.
> 
> Anthony asked me to send a patch to the list, asking form comments.
> 
> alpha:
> CC: Richard Henderson <address@hidden>
> 
> arm:
> CC: Andrzej Zaborowski <address@hidden>
> 
>   (it appears as balrog, but on irc channel peter told me that balrog
>   has him)
> 
> cris:
> CC: Edgar E. Iglesias <address@hidden>
> 
> i386:
> 
> Fabrice Bellard?
> 
>  * Copyright (c) 2003-2008 Fabrice Bellard
> 
> Didn't cc'd him because he left project/didn't have email address on
> MAINTAINERS/vl.c.  If you think that I should cc'd to him, just let me
> know.
> 
> lm32:
> 
> CC: Michael Walle <address@hidden>
> 
> mips:
> 
> Thiemo Seufer?
> 
> ppc & sparc:
> 
> CC: Blue Swirl <address@hidden>
> 
> 
> What do you think, what should we do?  Juan.
> 
> 
> 
> *** BLURB HERE ***
> 
> Juan Quintela (8):
>   vmstate: Add copyright info for alpha processor
>   vmstate: Add copyright info for lm32 processor
>   vmstate: Add copyright info for cris processor
>   vmstate: Add copyright info for arm processor
>   vmstate: Add copyright info for i386 processor
>   vmstate: Add copyright info for mips processor
>   vmstate: Add copyright info for ppc processor
>   vmstate: Add copyright info for sparc processor
> 
>  target-alpha/vmstate-cpu.c |   15 +++++++++++++++
>  target-arm/vmstate-cpu.c   |   15 +++++++++++++++
>  target-cris/vmstate-cpu.c  |   15 +++++++++++++++
>  target-i386/vmstate-cpu.c  |   28 ++++++++++++++++++++++++++++
>  target-lm32/vmstate-cpu.c  |   15 +++++++++++++++
>  target-mips/vmstate-cpu.c  |   29 +++++++++++++++++++++++++++++
>  target-ppc/vmstate-cpu.c   |   28 ++++++++++++++++++++++++++++
>  target-sparc/vmstate-cpu.c |   29 +++++++++++++++++++++++++++++
>  8 files changed, 174 insertions(+), 0 deletions(-)
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg