Re: [Qemu-devel] [PATCH 02/18] qom: register legacy properties as new style properties

[Anthony Liguori]

On 12/01/2011 09:51 AM, Gerd Hoffmann wrote:
>    Hi,
>
> > +    for (prop = dev->info->props; prop&&  prop->name; prop++) {
> > +        qdev_property_add_legacy(dev, prop, NULL);
> > +    }
>
> bus properties?

Hrm, okay, I can fix that.  Thanks for pointing that out.

> > +static void qdev_get_legacy_property(DeviceState *dev, Visitor *v, void 
> > *opaque,
> > +                                     const char *name, Error **errp)
> > +{
> > +    Property *prop = opaque;
> > +
> > +    if (prop->info->print) {
> > +        char buffer[1024];
> > +        char *ptr = buffer;
> > +
> > +        prop->info->print(dev, prop, buffer, sizeof(buffer));
> > +        visit_type_str(v,&ptr, name, errp);
>
> I think you can look at prop->info->type here and do something more
> clever at least for the bool + integer properties.

That might get a little tough because I want legacy<> types to be handled as 
strings.  I guess we could promote bool/int to non-legacy types.

Regards,

Anthony Liguori

> cheers,
>    Gerd