Re: [Qemu-devel] [RFC][PATCH 01/16] msi: Generalize msix_supported to msi_supported

[Avi Kivity]

On 12/03/2011 01:17 PM, Jan Kiszka wrote:
> From: Jan Kiszka <address@hidden>
>
> Rename msix_supported to msi_supported and control MSI and MSI-X
> activation this way. That was likely to original intention for this
> flag, but MSI support came after MSI-X.

'and' is a dangerous word in a changelog entry.

>
> +
> +    if (!msi_supported) {
> +        return -ENOTSUP;
> +    }
> +
>

This changes behaviour.  qemu 1.0 -M pc-1.0 and qemu-1.1 -M pc-1.0 will
be different after this, no?

-- 
error compiling committee.c: too many arguments to function