Re: [Qemu-devel] [RFC][PATCH 10/16] memory: Introduce memory_region_init_reservation

[Jan Kiszka]

On 2011-12-04 14:20, Avi Kivity wrote:
> On 12/03/2011 01:17 PM, Jan Kiszka wrote:
>> From: Jan Kiszka <address@hidden>
>>
>> Introduce a memory region type that can reserve I/O space. Such regions
>> are useful for modeling I/O that is only handled outside of QEMU, i.e.
>> in the context of an accelerator like KVM. Any access to such a region
>> from QEMU is a bug and will be reported as such.
> 
> This is guest triggerable (DMA into the region), so abort() is too drastic.

Mmh, true. Will turn it into a print-once warning.

> 
>> +void memory_region_init_reservation(MemoryRegion *mr,
>> +                                    const char *name,
>> +                                    uint64_t size)
>> +{
>> +    memory_region_init(mr, name, size);
>> +    mr->ops = &reservation_ops;
>> +    mr->opaque = mr;
>> +    mr->terminates = true;
>> +    mr->backend_registered = false;
>> +}
> 
> Just calling memory_region_init_io() is simpler, no?

Yep.

Thanks,
Jan

signature.asc
Description: OpenPGP digital signature