Re: [Qemu-devel] [PATCH v2 3/6] memory: introduce memory_region_set_alias_offset()

[Avi Kivity]

On 12/04/2011 11:34 PM, Blue Swirl wrote:
> On Sun, Dec 4, 2011 at 18:09, Avi Kivity <address@hidden> wrote:
> > Add an API to update an alias offset of an active alias.  This can be
> > used to simplify implementation of dynamic memory banks.
> >
> >  */
> > -void memory_region_set_address(MemoryRegion *mr, target_phys_addr_t addr);
> > +void memory_region_set_address(MemoryRegion *mr, target_phys_addr_t 
> > offset);
>
> This isn't the function you are looking for, but still 'addr' is
> changed to 'offset'.
>
> > +
> > +/*
> > + * memory_region_set_alias_offset: dynamically update a memory alias's 
> > offset
> > + *
> > + * Dynamically updates the offset into the target region that an alias 
> > points
> > + * to, as if the fourth argument to memory_region_init_alias() has changed.
> > + *
> > + * @mr: the #MemoryRegion to be updated; should be an alias.
> > + * @offset: the new offset into the target memory region
> > + */
> > +void memory_region_set_alias_offset(MemoryRegion *mr, target_phys_addr_t 
> > addr);
>
> Here 'addr' doesn't match the description above.

Thanks, fixed.

-- 
error compiling committee.c: too many arguments to function