Re: [Qemu-devel] [PATCH 14/14] s5pc210: Switch to sysbus_init_mmio.

[Peter Maydell]

On 7 December 2011 09:47, Evgeny Voevodin <address@hidden> wrote:
>
> Signed-off-by: Evgeny Voevodin <address@hidden>
> ---
>  hw/s5pc210_cmu.c      |    2 +-
>  hw/s5pc210_combiner.c |    2 +-
>  hw/s5pc210_fimd.c     |    2 +-
>  hw/s5pc210_gic.c      |    4 ++--
>  hw/s5pc210_mct.c      |    2 +-
>  hw/s5pc210_pwm.c      |    2 +-
>  hw/s5pc210_sdhc.c     |    2 +-
>  hw/s5pc210_uart.c     |    2 +-
>  8 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/hw/s5pc210_cmu.c b/hw/s5pc210_cmu.c
> index 12fba47..b8f0e5d 100644
> --- a/hw/s5pc210_cmu.c
> +++ b/hw/s5pc210_cmu.c
> @@ -1121,7 +1121,7 @@ static int s5pc210_cmu_init(SysBusDevice *dev)
>     /* memory mapping */
>     memory_region_init_io(&s->iomem, &s5pc210_cmu_ops, s, "s5pc210.cmu",
>                           S5PC210_CMU_REGS_MEM_SIZE);
> -    sysbus_init_mmio_region(dev, &s->iomem);
> +    sysbus_init_mmio(dev, &s->iomem);
>
>     qemu_register_reset(s5pc210_cmu_reset, s);

These changes need to be folded in with the earlier patches, otherwise
they will not compile. Each patch in the series should be correct as it
stands, not broken and fixed up by a later patch.

-- PMM