[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-img rebase: Fix for undersized backing fil
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-img rebase: Fix for undersized backing files |
Date: |
Wed, 7 Dec 2011 11:50:51 +0000 |
On Wed, Dec 7, 2011 at 11:45 AM, Kevin Wolf <address@hidden> wrote:
> Backing files may be smaller than the corresponding COW file. When
> reading directly from the backing file, qemu-img rebase must consider
> this and assume zero sectors after the end of backing files.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> qemu-img.c | 42 +++++++++++++++++++++++++++++++++---------
> 1 files changed, 33 insertions(+), 9 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
It almost feels like we want a bdrv_read() variation that does the
zeroing beyond end of image instead of duplicating this.
Stefan