Re: [Qemu-devel] [PATCH v2 09/18] qapi: allow a 'gen' key to suppress code generation

[Anthony Liguori]

On 12/08/2011 10:04 AM, Kevin Wolf wrote:
> Am 02.12.2011 21:20, schrieb Anthony Liguori:
> > Signed-off-by: Anthony Liguori<address@hidden>
> > ---
> >   scripts/qapi-commands.py |    1 +
> >   scripts/qapi-types.py    |    1 +
> >   2 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py
> > index f7def16..54d1f5d 100644
> > --- a/scripts/qapi-commands.py
> > +++ b/scripts/qapi-commands.py
> > @@ -405,6 +405,7 @@ except os.error, e:
> >
> >   exprs = parse_schema(sys.stdin)
> >   commands = filter(lambda expr: expr.has_key('command'), exprs)
> > +commands = filter(lambda expr: not expr.has_key('gen'), commands)
>
> Might be confusing if someone uses something like gen = True. Shouldn't
> we better check the value instead of just existence?

Yes, it was a lazy short cut.  I'll fix appropriately.

Regards,

Anthony Liguori

> Kevin