Re: [Qemu-devel] [PATCH 2/3] vl.c: Fold constant string into printf rather than using %s

[Andreas Färber]

Am 12.12.2011 09:21, schrieb Michael Ellerman:
> In help() we do what boils down to:
> 
>   printf("%s", "qemu");
> 
> This seems to be an artifact of be995c27640a82c7056b6f53d02ec823570114e5
> ("removed unused code"), which removed some ifdef'ery that used to print
> a different name depending on CONFIG_SOFTMMU.
> 
> But now that is gone and we always use "qemu" we may as well just put
> that in the format string.

I would rather propose to save argv[0] and use that. By now "qemu" is
not even correct for i386.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg