Re: [Qemu-devel] [PATCH 02/11] isa: move ISABus structure definition to header file

[Anthony Liguori]

On 10/24/2011 03:18 PM, Hervé Poussineau wrote:
> Signed-off-by: Hervé Poussineau<address@hidden>

Reviewed-by: Anthony Liguori <address@hidden>

Regards,

Anthony Liguori

> ---
>   hw/isa-bus.c |    5 -----
>   hw/isa.h     |    6 ++++++
>   2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/hw/isa-bus.c b/hw/isa-bus.c
> index dcbb134..7c94f0b 100644
> --- a/hw/isa-bus.c
> +++ b/hw/isa-bus.c
> @@ -22,11 +22,6 @@
>   #include "isa.h"
>   #include "exec-memory.h"
>
> -struct ISABus {
> -    BusState qbus;
> -    MemoryRegion *address_space_io;
> -    qemu_irq *irqs;
> -};
>   static ISABus *isabus;
>   target_phys_addr_t isa_mem_base = 0;
>
> diff --git a/hw/isa.h b/hw/isa.h
> index 4b58e37..0462521 100644
> --- a/hw/isa.h
> +++ b/hw/isa.h
> @@ -13,6 +13,12 @@ typedef struct ISABus ISABus;
>   typedef struct ISADevice ISADevice;
>   typedef struct ISADeviceInfo ISADeviceInfo;
>
> +struct ISABus {
> +    BusState qbus;
> +    MemoryRegion *address_space_io;
> +    qemu_irq *irqs;
> +};
> +
>   struct ISADevice {
>       DeviceState qdev;
>       uint32_t isairq[2];