Re: [Qemu-devel] [PATCH 03/11] i8259: give ISA device to isa_register_ioport()

[Anthony Liguori]

On 10/24/2011 03:18 PM, Hervé Poussineau wrote:
> Signed-off-by: Hervé Poussineau<address@hidden>

Reviewed-by: Anthony Liguori <address@hidden>

Regards,

Anthony Liguori

> ---
>   hw/i8259.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/i8259.c b/hw/i8259.c
> index 4446339..7331e0e 100644
> --- a/hw/i8259.c
> +++ b/hw/i8259.c
> @@ -469,9 +469,9 @@ static int pic_initfn(ISADevice *dev)
>       memory_region_init_io(&s->base_io,&pic_base_ioport_ops, s, "pic", 2);
>       memory_region_init_io(&s->elcr_io,&pic_elcr_ioport_ops, s, "elcr", 1);
>
> -    isa_register_ioport(NULL,&s->base_io, s->iobase);
> +    isa_register_ioport(dev,&s->base_io, s->iobase);
>       if (s->elcr_addr != -1) {
> -        isa_register_ioport(NULL,&s->elcr_io, s->elcr_addr);
> +        isa_register_ioport(dev,&s->elcr_io, s->elcr_addr);
>       }
>
>       qdev_init_gpio_out(&dev->qdev, s->int_out, ARRAY_SIZE(s->int_out));