Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

[Anthony Liguori]

On 12/13/2011 05:06 AM, Avi Kivity wrote:
> On 12/12/2011 06:26 PM, Anthony Liguori wrote:
> > Nope, it has to be dropped.
> >
> > Commands using CMD_ASYNC may fail in arbitrary ways because of the way
> > error reporting is done.  This is an unfixable problem until we
> > eliminate all uses of qerror_report().
>
> Why don't we eliminate all uses for qerror_report() then?  Breaking our
> interfaces instead seems like a horrible idea.

That's what Luiz is doing right now.

Regards,

Anthony Liguori

> > We need to take the hit here and force the command to always fail.
> > libvirt will need logic to use a different command with new versions.
> > If we coordinate this with the libvirt folks, we can make the
> > transition as smooth as possible.
>
> I thought we've outgrown this.  If we provide an interface, we should
> support it.