Re: [Qemu-devel] [PATCH v3 0/9] block: generic image streaming

[Yibin Shen]

hi stefan:

all these patches looks good to me except one thing,
when I run a "qemu-img commit" command,
seems entire image(from start to end sector) will be write to the backing file,
I think what we really need is to commit only dirty sectors.
also maybe we can use a writeback mechanism alternaively.

Yibin Shen


On Tue, Dec 13, 2011 at 9:52 PM, Stefan Hajnoczi
<address@hidden> wrote:
> This series adds the 'block_stream' command which copies the contents of a
> backing file into the image file while the VM is running.  The series builds 
> on
> copy-on-read and zero detection features which I sent out recently and I
> suggest grabbing my git tree to try it out without merging these dependencies
> yourself:
>
> http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/image-streaming-api
>
> The image streaming HMP/QMP commands are documented in the patch and also
> described here:
>
> http://wiki.qemu.org/Features/LiveBlockMigration/ImageStreamingAPI
>
> The basic idea is to execute 'block_stream virtio0' while the guest is 
> running.
> Progress can be monitored using 'info block-jobs'.  When the streaming
> operation completes it raises a QMP event.
>
> Note: The last patch includes includes a Python test script called
> test-stream.py, I do not propose to merge it.  When run in a QEMU source tree
> it performs basic image streaming QMP tests.
>
> Stefan Hajnoczi (9):
>  coroutine: add co_sleep_ns() coroutine sleep function
>  block: add BlockJob interface for long-running operations
>  block: add image streaming block job
>  block: rate-limit streaming operations
>  qmp: add block_stream command
>  qmp: add block_job_set_speed command
>  qmp: add block_job_cancel command
>  qmp: add query-block-jobs
>  test: add image streaming test cases
>
>  Makefile.objs          |    3 +-
>  block/stream.c         |  174 ++++++++++++++++++++++++++++++++++++++++
>  block_int.h            |   86 ++++++++++++++++++++
>  blockdev.c             |  143 +++++++++++++++++++++++++++++++++
>  hmp-commands.hx        |   41 ++++++++++
>  hmp.c                  |   81 +++++++++++++++++++
>  hmp.h                  |    4 +
>  monitor.c              |   13 +++
>  monitor.h              |    2 +
>  qapi-schema.json       |  144 +++++++++++++++++++++++++++++++++
>  qemu-coroutine-sleep.c |   38 +++++++++
>  qemu-coroutine.h       |    6 ++
>  qerror.c               |    4 +
>  qerror.h               |    3 +
>  qmp-commands.hx        |   93 +++++++++++++++++++++
>  test-stream.py         |  208 
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  trace-events           |    9 ++
>  17 files changed, 1051 insertions(+), 1 deletions(-)
>  create mode 100644 block/stream.c
>  create mode 100644 qemu-coroutine-sleep.c
>  create mode 100644 test-stream.py
>
> --
> 1.7.7.3
>
>

________________________________

This email (including any attachments) is confidential and may be legally 
privileged. If you received this email in error, please delete it immediately 
and do not copy it or use it for any purpose or disclose its contents to any 
other person. Thank you.

本电邮(包括任何附件)可能含有机密资料并受法律保护。如您不是正确的收件人，请您立即删除本邮件。请不要将本电邮进行复制并用作任何其他用途、或透露本邮件之内容。谢谢。