[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] spapr: Add support for -vga option
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] [PATCH] spapr: Add support for -vga option |
Date: |
Thu, 15 Dec 2011 11:00:46 +1100 |
On Wed, 2011-12-14 at 15:48 -0600, Anthony Liguori wrote:
> > /* USB */
> > if (usb_enabled) {
> >
> usb_ohci_init_pci(QLIST_FIRST(&spapr->phbs)->host_state.bus, -1);
> > + if (spapr_has_graphics) {
> > + usbdevice_create("keyboard");
> > + usbdevice_create("mouse");
>
> It is better to use usb_create() and pass it the usb bus directly as
> this will make it easier to express this as composition down the road.
How do I do that ? usb_ohci_init_pci() doesn't appear to return
the USB bus....
Cheers,
Ben.