[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/17] block: pass protocol flags up to the form
From: |
Zhi Yong Wu |
Subject: |
Re: [Qemu-devel] [PATCH 03/17] block: pass protocol flags up to the format |
Date: |
Thu, 15 Dec 2011 12:10:42 +0800 |
On Tue, Dec 13, 2011 at 8:37 PM, Paolo Bonzini <address@hidden> wrote:
> In the next patches, the protocols will modify bs->open_flags to signify
> that they cannot support the exact requested feature set. Pass the
> modified flags to the format.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> block.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/block.c b/block.c
> index fa11e3a..6734e66 100644
> --- a/block.c
> +++ b/block.c
> @@ -612,8 +612,9 @@ static int bdrv_open_common(BlockDriverState *bs, const
> char *filename,
> ret = drv->bdrv_file_open(bs, filename, open_flags);
> } else {
> ret = bdrv_file_open(&bs->file, filename, open_flags);
> + bs->open_flags = bs->file->open_flags;
> if (ret >= 0) {
> - ret = drv->bdrv_open(bs, open_flags);
> + ret = drv->bdrv_open(bs, bs->file->open_flags);
s/bs->file->open_flags/bs->open_flags/, it is more reasonable to use
bs->open_flags here.
> }
> }
>
> --
> 1.7.7.1
>
>
>
--
Regards,
Zhi Yong Wu
- [Qemu-devel] [PATCH 00/17] Support mismatched host and guest logical block sizes, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 01/17] block: do not rely on open_flags for bdrv_is_snapshot, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 02/17] block: store actual flags in bs->open_flags, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 05/17] block: remove enable_write_cache, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 03/17] block: pass protocol flags up to the format, Paolo Bonzini, 2011/12/13
- Re: [Qemu-devel] [PATCH 03/17] block: pass protocol flags up to the format,
Zhi Yong Wu <=
- [Qemu-devel] [PATCH 04/17] block: non-raw protocols never cache, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 06/17] block: move flag bits together, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 07/17] raw: remove the aligned_buf, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 08/17] block: rename buffer_alignment to guest_block_size, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 09/17] block: add host_block_size, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 11/17] iscsi: save host block size, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 12/17] block: allow waiting only for overlapping writes, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 10/17] raw: probe host_block_size, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 16/17] block: default physical block size to host block size, Paolo Bonzini, 2011/12/13
- [Qemu-devel] [PATCH 14/17] block: protect against "torn reads" for guest_block_size > host_block_size, Paolo Bonzini, 2011/12/13