qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 2/9] block: add BlockJob interface for long-r


From: Marcelo Tosatti
Subject: Re: [Qemu-devel] [PATCH v3 2/9] block: add BlockJob interface for long-running operations
Date: Thu, 15 Dec 2011 08:40:08 -0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Dec 14, 2011 at 02:51:47PM +0100, Kevin Wolf wrote:
> Am 13.12.2011 14:52, schrieb Stefan Hajnoczi:
> > Signed-off-by: Stefan Hajnoczi <address@hidden>
> > ---
> >  block_int.h |   83 
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 83 insertions(+), 0 deletions(-)
> 
> Why are these functions static inline in the header instead of being
> implemented in block.c?
> 
> The other thing I was going to ask, but don't really know to which patch
> I should reply, is whether we need to take care of bdrv_close/delete
> while a block job is still running. What happens if you unplug a device
> that is being streamed?

There is an additional reference, its not deleted until the operation
completes. Or at least it should be like that, Stefan?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]