qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and compositio


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH v3 00/20] qom: dynamic properties and composition tree
Date: Fri, 16 Dec 2011 07:49:10 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13

On 12/16/2011 04:17 AM, Paolo Bonzini wrote:
On 12/16/2011 10:42 AM, Kevin Wolf wrote:
>
> Applied.
>
> Regards,
>
> Anthony Liguori
So you pushed this with qdev_property_add_child() calls spread all over
the place instead of being treated like other properties?:-(

I think actually this is not the biggest problem. child properties are dynamic,
and it's not a problem IMO if they are created like that.

I don't like that _link_ properties are spread all over the place instead of
being treated like other properties. Link properties are static, and PROP_PTR
properties could often be converted to links.

With your new series, we should be able to add a DEFINE_PROP_LINK() that does the right thing I guess. I've got no objection to that.

Regards,

Anthony Liguori


I'm playing with separating the "legacy" and "static" property concepts so that
we can head in that direction. I hope to send out an RFC in an hour or so.

Paolo





reply via email to

[Prev in Thread] Current Thread [Next in Thread]