[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] Device isolation infrastructure v2
From: |
Joerg Roedel |
Subject: |
Re: [Qemu-devel] [RFC] Device isolation infrastructure v2 |
Date: |
Fri, 16 Dec 2011 15:53:53 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Dec 15, 2011 at 11:05:07AM -0700, Alex Williamson wrote:
> Starting with it in the core and hand waving some future use that we
> don't plan to implement right now seems like the wrong direction.
I agree with Alex. First of all, I havn't seen any real vfio problem
that can't be solved with the current approach, and it has the great
advantage of simplicity. It doesn't require a re-implementation of the
driver-core based on groups. I agree that we need some improvements to
Alex' code for the dma-api layer to solve the problem with broken devices
using the wrong requestor-id. But that can be done incrementally with
the current (current == in the iommu-tree) approach implemented by Alex.
I also think that all this does not belong into the driver core for two
reasons:
1) The information for building the device groups is provided
by the iommu-layer
2) The group information is provided to vfio by the iommu-api
This makes the iommu-layer the logical point to place the grouping code.
There are some sources outside of the iommu-layer that may influence
grouping (like pci-quirks), but most of the job is done by the
iommu-drivers.
Thanks,
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
- [Qemu-devel] [RFC] Device isolation infrastructure v2, David Gibson, 2011/12/15
- [Qemu-devel] [PATCH 2/3] device_isolation: Support isolation on POWER p5ioc2 bridges, David Gibson, 2011/12/15
- [Qemu-devel] [PATCH 1/3] device_isolation: Infrastructure for managing device isolation groups, David Gibson, 2011/12/15
- [Qemu-devel] [PATCH 3/3] device_isolation: Support isolation on POWER p7ioc (IODA) bridges, David Gibson, 2011/12/15
- Re: [Qemu-devel] [RFC] Device isolation infrastructure v2, Alex Williamson, 2011/12/15
- Re: [Qemu-devel] [RFC] Device isolation infrastructure v2,
Joerg Roedel <=
- Re: [Qemu-devel] [RFC] Device isolation infrastructure v2, David Gibson, 2011/12/18
- Re: [Qemu-devel] [RFC] Device isolation infrastructure v2, Joerg Roedel, 2011/12/19
- Re: [Qemu-devel] [RFC] Device isolation infrastructure v2, David Gibson, 2011/12/20
- Re: [Qemu-devel] [RFC] Device isolation infrastructure v2, Alex Williamson, 2011/12/20
- Re: [Qemu-devel] [RFC] Device isolation infrastructure v2, Aaron Fabbri, 2011/12/21
- Re: [Qemu-devel] [RFC] Device isolation infrastructure v2, Joerg Roedel, 2011/12/21
- Re: [Qemu-devel] [RFC] Device isolation infrastructure v2, David Woodhouse, 2011/12/19
- Re: [Qemu-devel] [RFC] Device isolation infrastructure v2, David Gibson, 2011/12/19
- Re: [Qemu-devel] [RFC] Device isolation infrastructure v2, David Woodhouse, 2011/12/19
- Re: [Qemu-devel] [RFC] Device isolation infrastructure v2, David Gibson, 2011/12/19