[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 1/5] vl.c: Do not save RAM state when Xen is
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH V2 1/5] vl.c: Do not save RAM state when Xen is used. |
Date: |
Sun, 18 Dec 2011 19:44:55 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 |
On 12/15/2011 05:12 PM, Anthony Liguori wrote:
> On 12/09/2011 03:54 PM, Anthony PERARD wrote:
>> In Xen case, the guest RAM is not handle by QEMU, and it is saved by
>> Xen tools.
>> So, we just avoid to register the RAM save state handler.
>>
>> - register_savevm_live(NULL, "ram", 0, 4, NULL, ram_save_live, NULL,
>> - ram_load, NULL);
>> + if (!xen_enabled()) {
>> + register_savevm_live(NULL, "ram", 0, 4, NULL, ram_save_live,
>> NULL,
>> + ram_load, NULL);
>> + }
>
> Why don't you just unregister the section in the xen initialization
> code? That way we don't have xen_enabled()'s sprinkled all over the
> place.
It's better to see them up front, having the magical string "ram"
connect the two is hard to follow.
--
error compiling committee.c: too many arguments to function
[Qemu-devel] [PATCH V2 4/5] xen: Change memory access behavior during migration., Anthony PERARD, 2011/12/09
[Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen., Anthony PERARD, 2011/12/09