[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/3] sysbus: remove sysbus_init_mmio_cb2
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 3/3] sysbus: remove sysbus_init_mmio_cb2 |
|
Date: |
Sun, 18 Dec 2011 23:00:48 +0000 |
On 16 December 2011 22:37, Benoît Canet <address@hidden> wrote:
> This function is not longer in use so remove it.
>
> Signed-off-by: Benoît Canet <address@hidden>
Nothing wrong here, but you can go further: it's now the case that
for all mmio regions s->mmio[n].memory is non-NULL, so you can remove
some if() conditionals in sysbus_mmio_map() and sysbus_dev_print().
-- PMM