[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/23] fixup: listener fixes
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 12/23] fixup: listener fixes |
Date: |
Mon, 19 Dec 2011 14:32:28 +0000 |
On 19 December 2011 14:13, Avi Kivity <address@hidden> wrote:
> ---
This is a rather uninformative commit message -- was this patch
intended to be in this series?
-- PMM
> memory.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/memory.c b/memory.c
> index c08186d..2dcbf80 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -708,13 +708,13 @@ static void memory_listener_update_region(FlatRange
> *fr, AddressSpace *as,
> .address_space = as->root,
> .offset_within_region = fr->offset_in_region,
> .size = int128_get64(fr->addr.size),
> - .offset_within_region = int128_get64(fr->addr.start),
> + .offset_within_address_space = int128_get64(fr->addr.start),
> };
> MemoryListener *listener;
>
> QLIST_FOREACH(listener, &memory_listeners, link) {
> ListenerCallback *callback
> - = *(ListenerCallback *)((void *)listener + callback_offset);
> + = *(ListenerCallback **)((void *)listener + callback_offset);
> callback(listener, §ion);
> }
> }
> @@ -1149,6 +1149,7 @@ void memory_region_sync_dirty_bitmap(MemoryRegion *mr)
>
> FOR_EACH_FLAT_RANGE(fr, &address_space_memory.current_map) {
> if (fr->mr == mr) {
> + MEMORY_LISTENER_UPDATE_REGION(fr, &address_space_memory,
> log_sync);
> cpu_physical_sync_dirty_bitmap(int128_get64(fr->addr.start),
>
> int128_get64(addrrange_end(fr->addr)));
> }
> @@ -1467,7 +1468,7 @@ static void listener_add_address_space(MemoryListener
> *listener,
> .address_space = as->root,
> .offset_within_region = fr->offset_in_region,
> .size = int128_get64(fr->addr.size),
> - .offset_within_region = int128_get64(fr->addr.start),
> + .offset_within_address_space = int128_get64(fr->addr.start),
> };
> listener->region_add(listener, §ion);
> }
> --
> 1.7.7.1
>
>
- [Qemu-devel] [PATCH 04/23] framebuffer: drop use of cpu_get_physical_page_desc(), (continued)
- [Qemu-devel] [PATCH 04/23] framebuffer: drop use of cpu_get_physical_page_desc(), Avi Kivity, 2011/12/19
- [Qemu-devel] [PATCH 19/23] kvm: avoid cpu_get_physical_page_desc(), Avi Kivity, 2011/12/19
- [Qemu-devel] [PATCH 11/23] kvm: switch kvm slots to use host virtual address instead of ram_addr_t, Avi Kivity, 2011/12/19
- [Qemu-devel] [PATCH 16/23] memory: temporarily add memory_region_get_ram_addr(), Avi Kivity, 2011/12/19
- [Qemu-devel] [PATCH 03/23] memory: add memory_region_is_ram(), Avi Kivity, 2011/12/19
- [Qemu-devel] [PATCH 20/23] vhost: avoid cpu_get_physical_page_desc(), Avi Kivity, 2011/12/19
- [Qemu-devel] [PATCH 15/23] xen, vga: add API for registering the framebuffer, Avi Kivity, 2011/12/19
- [Qemu-devel] [PATCH 12/23] fixup: listener fixes, Avi Kivity, 2011/12/19
- Re: [Qemu-devel] [PATCH 12/23] fixup: listener fixes,
Peter Maydell <=
- [Qemu-devel] [PATCH 01/23] memory: introduce memory_region_find(), Avi Kivity, 2011/12/19
- Re: [Qemu-devel] [PATCH 01/23] memory: introduce memory_region_find(), Anthony Liguori, 2011/12/19
- Re: [Qemu-devel] [PATCH 01/23] memory: introduce memory_region_find(), Avi Kivity, 2011/12/19
- Re: [Qemu-devel] [PATCH 01/23] memory: introduce memory_region_find(), Anthony Liguori, 2011/12/19
- Re: [Qemu-devel] [PATCH 01/23] memory: introduce memory_region_find(), Avi Kivity, 2011/12/19
- Re: [Qemu-devel] [PATCH 01/23] memory: introduce memory_region_find(), Anthony Liguori, 2011/12/19
- Re: [Qemu-devel] [PATCH 01/23] memory: introduce memory_region_find(), Avi Kivity, 2011/12/19
- Re: [Qemu-devel] [PATCH 01/23] memory: introduce memory_region_find(), Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 17/23] xen: convert to MemoryListener API, Avi Kivity, 2011/12/19