Re: [Qemu-devel] [PULL 0/2] Plan obsolescense of exec.c memory functions

[Anthony Liguori]

On 12/15/2011 07:35 AM, Avi Kivity wrote:
> Exile some exec.c functions to a private header, to prevent accidental reuse.
>
> Please pull from
>
>    git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/exec-obsolete

This breaks the Xen build.  Perhaps we need to merge your patches to convert Xen 
to the memory API first?

cc1: warnings being treated as errors
/home/anthony/git/qemu/xen-all.c: In function ‘xen_ram_init’:
/home/anthony/git/qemu/xen-all.c:169:5: error: implicit declaration of function 
‘cpu_register_physical_memory’
/home/anthony/git/qemu/xen-all.c:169:5: error: nested extern declaration of 
‘cpu_register_physical_memory’
make[1]: *** [xen-all.o] Error 1

Regards,

Anthony Liguori

> Avi Kivity (2):
>    etraxfs_eth: drop bogus cpu_unregister_io_memory()
>    memory: move obsolete exec.c functions to a private header
>
>   cpu-common.h     |   36 -----------------------------
>   exec-obsolete.h  |   66 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   exec.c           |    3 ++
>   hw/etraxfs_eth.c |    3 --
>   memory.c         |    3 ++
>   5 files changed, 72 insertions(+), 39 deletions(-)
>   create mode 100644 exec-obsolete.h