[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 08/23] memory: replace cpu_physical_sync_dirty_bitma
From: |
Avi Kivity |
Subject: |
[Qemu-devel] [PATCH 08/23] memory: replace cpu_physical_sync_dirty_bitmap() with a memory API |
Date: |
Mon, 19 Dec 2011 16:13:29 +0200 |
The function is still used as the implementation.
Signed-off-by: Avi Kivity <address@hidden>
---
arch_init.c | 6 ++----
cpu-all.h | 3 ---
exec-obsolete.h | 3 +++
memory.c | 4 ++++
memory.h | 10 ++++++++++
5 files changed, 19 insertions(+), 7 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index a411fdf..ceef26e 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -41,6 +41,7 @@
#include "net.h"
#include "gdbstub.h"
#include "hw/smbios.h"
+#include "exec-memory.h"
#ifdef TARGET_SPARC
int graphic_width = 1024;
@@ -263,10 +264,7 @@ int ram_save_live(Monitor *mon, QEMUFile *f, int stage,
void *opaque)
return 0;
}
- if (cpu_physical_sync_dirty_bitmap(0, TARGET_PHYS_ADDR_MAX) != 0) {
- qemu_file_set_error(f, -EINVAL);
- return -EINVAL;
- }
+ memory_global_sync_dirty_bitmap(get_system_memory());
if (stage == 1) {
RAMBlock *block;
diff --git a/cpu-all.h b/cpu-all.h
index 9d78715..f2c5382 100644
--- a/cpu-all.h
+++ b/cpu-all.h
@@ -569,9 +569,6 @@ int cpu_physical_memory_set_dirty_tracking(int enable);
int cpu_physical_memory_get_dirty_tracking(void);
-int cpu_physical_sync_dirty_bitmap(target_phys_addr_t start_addr,
- target_phys_addr_t end_addr);
-
int cpu_physical_log_start(target_phys_addr_t start_addr,
ram_addr_t size);
diff --git a/exec-obsolete.h b/exec-obsolete.h
index 1d0b610..aa0a04d 100644
--- a/exec-obsolete.h
+++ b/exec-obsolete.h
@@ -64,6 +64,9 @@ static inline void
cpu_register_physical_memory(target_phys_addr_t start_addr,
void qemu_register_coalesced_mmio(target_phys_addr_t addr, ram_addr_t size);
void qemu_unregister_coalesced_mmio(target_phys_addr_t addr, ram_addr_t size);
+int cpu_physical_sync_dirty_bitmap(target_phys_addr_t start_addr,
+ target_phys_addr_t end_addr);
+
#endif
#endif
diff --git a/memory.c b/memory.c
index c57b7de..639f3b1 100644
--- a/memory.c
+++ b/memory.c
@@ -1383,6 +1383,10 @@ MemoryRegionSection memory_region_find(MemoryRegion
*address_space,
return ret;
}
+void memory_global_sync_dirty_bitmap(MemoryRegion *address_space)
+{
+ cpu_physical_sync_dirty_bitmap(0, TARGET_PHYS_ADDR_MAX);
+}
void set_system_memory_map(MemoryRegion *mr)
{
diff --git a/memory.h b/memory.h
index 42546c4..3e27593 100644
--- a/memory.h
+++ b/memory.h
@@ -552,6 +552,16 @@ void memory_region_del_subregion(MemoryRegion *mr,
MemoryRegionSection memory_region_find(MemoryRegion *address_space,
target_phys_addr_t addr, uint64_t size);
+
+/**
+ * memory_global_sync_dirty_bitmap: synchronize the dirty log for all memory
+ *
+ * Synchronizes the dirty page log for an entire address space.
+ * @address_space: a top-level (i.e. parentless) region that contains the
+ * memory being synchronized
+ */
+void memory_global_sync_dirty_bitmap(MemoryRegion *address_space);
+
/**
* memory_region_transaction_begin: Start a transaction.
*
--
1.7.7.1
- Re: [Qemu-devel] [PATCH 14/23] vhost: convert to MemoryListener API, (continued)
[Qemu-devel] [PATCH 21/23] virtio-balloon: avoid cpu_get_physical_page_desc(), Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 07/23] framebuffer: drop use of cpu_physical_sync_dirty_bitmap(), Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 02/23] sysbus: add sysbus_address_space(), Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 23/23] Remove cpu_get_physical_page_desc(), Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 22/23] sparc: avoid cpu_get_physical_page_desc(), Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 13/23] kvm: convert to MemoryListener API, Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 08/23] memory: replace cpu_physical_sync_dirty_bitmap() with a memory API,
Avi Kivity <=
[Qemu-devel] [PATCH 18/23] memory: remove CPUPhysMemoryClient, Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 10/23] memory: add memory_region_is_logging(), Avi Kivity, 2011/12/19
Re: [Qemu-devel] [PATCH 00/23] Remove cpu_get_physical_page_desc(), Anthony Liguori, 2011/12/19