qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 01/10] qapi: add Visitor interfaces for uint*


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 01/10] qapi: add Visitor interfaces for uint*_t and int*_t
Date: Tue, 20 Dec 2011 13:00:26 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1

On 12/20/2011 12:43 PM, Paolo Bonzini wrote:

1) You can still add a vtable to QEMUFile for "visit_type_int*" and
"visit_type_uint*".  But this vtable doesn't need start/end callbacks.

Here I meant something simple like:

    void (*visit_type_int16) (QEMUFile *f, int16_t *x);

that is really the same as qemu_{get,put}_be16s and friends.

It may even be not a vtable, but a function that dispatches based on the existing get_buffer/put_buffer callbacks: note that one of them is always NULL. Which also means that the is_write field is superfluous. So much cleanup to do. :(

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]