[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] hw/omap1.c: Separate clkm from omap_mpu_sta
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] hw/omap1.c: Separate clkm from omap_mpu_state |
Date: |
Wed, 21 Dec 2011 11:07:03 +0000 |
On 21 December 2011 01:38, andrzej zaborowski <address@hidden> wrote:
> Since this sub device uses parts of the rest of mpu state, it's
> (apparently) not a separate device, can we thus skip this change? I
> don't see much value in it and it doesn't simplify code.
If you like; I don't have a very strong feeling about it, I'm mostly
just trying to get patches out of my tree, so "drop patch" is as
good as "push to master" in that sense :-)
I do suspect that nested anonymous structs are going to be a pain
for VMState if we ever get to adding save/load support to omap3.
> (note the parens in *(s->clkm) are redundant. Also would be great if
> your patches could maintain the indentation of the rest of the file
> where it's not specified by the new coding style, this would reduce
> inconsistency).
I mostly try not to make spurious indentation changes, but there
are a lot in the patches I inherited from the qemu-meego tree so
sometimes things slip through.
-- PMM
- [Qemu-devel] [PATCH 0/6] omap1: Separate omap1 subdevices from omap_mpu_state, Peter Maydell, 2011/12/20
- [Qemu-devel] [PATCH 3/6] hw/omap1.c: Separate PWT from omap_mpu_state, Peter Maydell, 2011/12/20
- [Qemu-devel] [PATCH 6/6] hw/omap1.c: Drop unused includes, Peter Maydell, 2011/12/20
- [Qemu-devel] [PATCH 2/6] hw/omap1.c: Separate PWL from omap_mpu_state, Peter Maydell, 2011/12/20
- [Qemu-devel] [PATCH 1/6] hw/omap1.c: omap_mpuio_init() need not be public, Peter Maydell, 2011/12/20
- [Qemu-devel] [PATCH 5/6] hw/omap1.c: Separate clkm from omap_mpu_state, Peter Maydell, 2011/12/20
- [Qemu-devel] [PATCH 4/6] hw/omap1.c: Separate dpll_ctl from omap_mpu_state, Peter Maydell, 2011/12/20