[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 13/26] move corking functions to osdep.c
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 13/26] move corking functions to osdep.c |
Date: |
Fri, 23 Dec 2011 16:26:17 +0100 |
Signed-off-by: Paolo Bonzini <address@hidden>
---
block/sheepdog.c | 20 ++------------------
osdep.c | 9 +++++++++
qemu_socket.h | 1 +
3 files changed, 12 insertions(+), 18 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 00ea5a0..17a79be 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -702,22 +702,6 @@ static int aio_flush_request(void *opaque)
return !QLIST_EMPTY(&s->outstanding_aio_head);
}
-#if !defined(SOL_TCP) || !defined(TCP_CORK)
-
-static int set_cork(int fd, int v)
-{
- return 0;
-}
-
-#else
-
-static int set_cork(int fd, int v)
-{
- return setsockopt(fd, SOL_TCP, TCP_CORK, &v, sizeof(v));
-}
-
-#endif
-
static int set_nodelay(int fd)
{
int ret, opt;
@@ -923,7 +907,7 @@ static int coroutine_fn add_aio_request(BDRVSheepdogState
*s, AIOReq *aio_req,
s->co_send = qemu_coroutine_self();
qemu_aio_set_fd_handler(s->fd, co_read_response, co_write_request,
aio_flush_request, NULL, s);
- set_cork(s->fd, 1);
+ socket_set_cork(s->fd, 1);
/* send a header */
ret = qemu_co_send(s->fd, &hdr, sizeof(hdr));
@@ -942,7 +926,7 @@ static int coroutine_fn add_aio_request(BDRVSheepdogState
*s, AIOReq *aio_req,
}
}
- set_cork(s->fd, 0);
+ socket_set_cork(s->fd, 0);
qemu_aio_set_fd_handler(s->fd, co_read_response, NULL,
aio_flush_request, NULL, s);
qemu_co_mutex_unlock(&s->lock);
diff --git a/osdep.c b/osdep.c
index 70bad27..3e6bada 100644
--- a/osdep.c
+++ b/osdep.c
@@ -48,6 +48,15 @@ extern int madvise(caddr_t, size_t, int);
#include "trace.h"
#include "qemu_socket.h"
+int socket_set_cork(int fd, int v)
+{
+#if defined(SOL_TCP) && defined(TCP_CORK)
+ return setsockopt(fd, SOL_TCP, TCP_CORK, &v, sizeof(v));
+#else
+ return 0;
+#endif
+}
+
int qemu_madvise(void *addr, size_t len, int advice)
{
if (advice == QEMU_MADV_INVALID) {
diff --git a/qemu_socket.h b/qemu_socket.h
index 9e32fac..fe4cf6c 100644
--- a/qemu_socket.h
+++ b/qemu_socket.h
@@ -35,6 +35,7 @@ int inet_aton(const char *cp, struct in_addr *ia);
/* misc helpers */
int qemu_socket(int domain, int type, int protocol);
int qemu_accept(int s, struct sockaddr *addr, socklen_t *addrlen);
+int socket_set_cork(int fd, int v);
void socket_set_block(int fd);
void socket_set_nonblock(int fd);
int send_all(int fd, const void *buf, int len1);
--
1.7.7.1
- [Qemu-devel] [PULL 00/26] nbd refactoring, fully asynchronous operation, flushing, fixes, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 01/26] add qemu_send_full and qemu_recv_full, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 02/26] sheepdog: move coroutine send/recv function to generic code, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 03/26] nbd: switch to asynchronous operation, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 04/26] nbd: split requests, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 08/26] nbd: add support for NBD_CMD_FLUSH, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 06/26] nbd: fix error handling in the server, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 05/26] nbd: allow multiple in-flight requests, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 10/26] Update ioctl order in nbd_init() to detect EBUSY, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 12/26] qemu-nbd: remove data_size argument to nbd_trip, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 13/26] move corking functions to osdep.c,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 14/26] qemu-nbd: simplify nbd_trip, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 15/26] qemu-nbd: introduce nbd_do_send_reply, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 16/26] qemu-nbd: more robust handling of invalid requests, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 19/26] qemu-nbd: introduce NBDRequest, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 20/26] link the main loop and its dependencies into the tools, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 22/26] qemu-nbd: move client handling to nbd.c, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 21/26] qemu-nbd: use common main loop, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 25/26] qemu-nbd: throttle requests, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 26/26] nbd: add myself as maintainer, Paolo Bonzini, 2011/12/23
- [Qemu-devel] [PATCH 07/26] nbd: add support for NBD_CMD_FLAG_FUA, Paolo Bonzini, 2011/12/23