[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] hw/: Introduce spec. ver. 2.00 compliant SD
From: |
malc |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] hw/: Introduce spec. ver. 2.00 compliant SD host controller |
Date: |
Mon, 26 Dec 2011 15:35:28 +0400 (MSK) |
User-agent: |
Alpine 2.00 (LNX 1167 2008-08-23) |
On Mon, 26 Dec 2011, Mitsyanko Igor wrote:
> This patch adds implementation of "SD specification version 2.00" compliant
> SD host controller. Also it provides interface to implement SoC-specific
> controllers on top of this specification-compliant one.
>
[..snip..]
> +
> +void sdhcv2_reset(SDHCv2State *s)
> +{
> + unsigned long begin = (unsigned long)s + offsetof(SDHCv2State,
> sdmasysad);
This is wrong,
uintptr_t begin = (uintptr_t) &s->sdmasysad;
Caveat emptor: i haven't tried to understand what the code tries to
accomplish, so maybe there's a way that doesn't involve even the above.
[..snip..]
--
mailto:address@hidden
- [Qemu-devel] [PATCH V2 1/3] vmstate: introduce get_bufsize entry in VMStateField, (continued)
[Qemu-devel] [PATCH 3/3] hw/: Introduce spec. ver. 2.00 compliant SD host controller, Mitsyanko Igor, 2011/12/26
- Re: [Qemu-devel] [PATCH 3/3] hw/: Introduce spec. ver. 2.00 compliant SD host controller,
malc <=
[Qemu-devel] [PATCH V2 0/3] Improve SD controllers emulation, Mitsyanko Igor, 2011/12/28
[Qemu-devel] [PATCH V2 3/3] hw: Introduce spec. ver. 2.00 compliant SD host controller, Mitsyanko Igor, 2011/12/28
[Qemu-devel] [PATCH V3 0/5] Improve SD controllers emulation, Mitsyanko Igor, 2011/12/28