[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty |
Date: |
Thu, 29 Dec 2011 19:56:58 +0530 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On (Thu) 29 Dec 2011 [15:16:55], Christian Borntraeger wrote:
> >> +++ b/hw/virtio-serial-bus.c
> >> @@ -163,7 +163,19 @@ static void do_flush_queued_data(VirtIOS
> >> abort();
> >> }
> >> if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
> >> - virtio_serial_throttle_port(port, true);
> >
> > I'm surprised: did you test this with upstream qemu? That codebase
> > doesn't yet throttle writes, and this code path won't execute. Does
> > it really not reproduce with this patch?
>
> I think
> static void handle_output(VirtIODevice *vdev, VirtQueue *vq)
> [....]
> if (!port->throttled) {
> do_flush_queued_data(port, vq, vdev);
> return;
>
> makes a difference here, since we will never return the buffer to the guest,
> no?
port->throttled never becomes true for qemu. I'm just unsure how this
patch works for you :)
Amit
- [Qemu-devel] [RFC] virtio-console fails on unconnected pty, Christian Borntraeger, 2011/12/15
- Re: [Qemu-devel] [RFC] virtio-console fails on unconnected pty, Amit Shah, 2011/12/16
- [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Christian Borntraeger, 2011/12/29
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Amit Shah, 2011/12/29
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Amit Shah, 2011/12/29
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Christian Borntraeger, 2011/12/29
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Christian Borntraeger, 2011/12/29
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty,
Amit Shah <=
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Christian Borntraeger, 2011/12/29
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Amit Shah, 2011/12/29
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Christian Borntraeger, 2011/12/29
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Amit Shah, 2011/12/29