Re: [Qemu-devel] [PATCH 2/3] target-mips:enabling of 64 bit user mode and floating point operations MIPS_HFLAG_UX is included in env->hflags so that the address computation for LD instruction does not treated as 32 bit code see gen_op_addr_add() in t

[Andreas Färber]

Am 31.12.2011 08:42, schrieb Khansa Butt:
> On Fri, Dec 9, 2011 at 5:04 AM, Andreas Färber <address@hidden> wrote:
>> Am 08.12.2011 06:25, schrieb address@hidden:
>>> diff --git a/target-mips/translate.c b/target-mips/translate.c
>>> index d5b1c76..452a63b 100644
>>> --- a/target-mips/translate.c
>>> +++ b/target-mips/translate.c
>>> @@ -12779,6 +12779,10 @@ void cpu_reset (CPUMIPSState *env)
>>>          env->hflags |= MIPS_HFLAG_FPU;
>>>      }
>>>  #ifdef TARGET_MIPS64
>>> +    env->hflags |=  MIPS_HFLAG_UX;
>>
>> So for those of us not knowing mips, it's defined as:
>>
>> #define MIPS_HFLAG_UX     0x00200 /* 64-bit user mode                 */
>>
>> The code above is inside CONFIG_USER_ONLY, so this looks right for n64
>> but not for n32 ABI.
>>
>> If you put this into its own patch with a description of
>>
>> ---8<---
>> target-mips: Enable 64 bit user mode for n64
>>
>> For user mode n64 ABI emulation, MIPS_HFLAG_UX is included in
>> env->hflags so that the address computation for LD instruction does not
>> get treated as 32 bit code, see gen_op_addr_add() in translate.c.
>>
>> Signed-off-by: Abdul Qadeer <address@hidden>
>> Signed-off-by: (you)
>> ---8<---
>>
>> and make it depend on TARGET_ABI_MIPSN64 then I will happily add my
>> Acked-by.
>>
> Why this is necessary to put "env->hflags |=  MIPS_HFLAG_UX;" line under
> TARGET_ABI_MIPSN64? as this was already put  under #if TARGET_MIPS64, is not
> it suffient?

You're right. I was under the impression that both n32 and n64 were
based off mips64, but mipsn32 is in fact based off mips. Adding NUBI64
support (as opposed to NUBI64W) would then probably be based off mips as
well then. Quite confusing.

So yes, no need to add #if defined(TARGET_ABI_MIPSN64) there, but do put
it in its own patch with a description explaining why.

Andreas