[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty |
Date: |
Mon, 02 Jan 2012 16:41:57 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.24) Gecko/20111108 Lightning/1.0b2 Thunderbird/3.1.16 |
On 02/01/12 16:34, Alexander Graf wrote:
>>> if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
>>> virtio_serial_throttle_port(port, true);
>>
>> Ah; I see what's happening. pty_chr_write() returns 0 if a client
>> isn't yet connected.
>>
>> This is different from the buggy tcp_chr_write() code, which just
>> returns 'len', i.e. a successful write. And since I've only tested
>> with tcp/unix sockets, I couldn't see why throttling could get
>> enabled.
>
> So what's the conclusion then? :)
My conclusion is that with my patch virtio-console on a pty works, without
it doesnt. :-)
I think Amit said that he is going to apply the patch.
Christian