Re: [Qemu-devel] [PATCH 01/27] qom: add the base Object class

[Paolo Bonzini]

On 12/20/2011 05:51 PM, Anthony Liguori wrote:
>   hw/object.c   |  469 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   hw/object.h   |  427 +++++++++++++++++++++++++++++++++++++++++++++++++++

A couple more remarks:

1) Please put it outside hw/

2) Why do you need a list for the interface objects at all?  You can 
make obj->interfaces point to a single blob, and initialize the objects 
in place.  You only need to store the number of interfaces into the 
TypeImpl or in the object header, or add a dummy Interface at the end 
whose contents are all-zero.

Paolo