[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/8] notifier: switch to QLIST
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 1/8] notifier: switch to QLIST |
Date: |
Tue, 3 Jan 2012 12:09:37 +0000 |
On Tue, Jan 3, 2012 at 11:59 AM, Paolo Bonzini <address@hidden> wrote:
> On 01/03/2012 12:54 PM, Stefan Hajnoczi wrote:
>>
>> On Mon, Jan 02, 2012 at 07:00:30PM +0100, Paolo Bonzini wrote:
>>>
>>> void notifier_list_add(NotifierList *list, Notifier *notifier)
>>> {
>>> - QTAILQ_INSERT_HEAD(&list->notifiers, notifier, node);
>>> + QLIST_INSERT_HEAD(&list->notifiers, notifier, node);
>>> }
>>>
>>> -void notifier_list_remove(NotifierList *list, Notifier *notifier)
>>> +void notifier_remove(Notifier *notifier)
>>
>>
>> Why introduce this asymmetry with notifier_list_add() and
>> notifier_remove()? Please make the function names consistent.
>
>
> Because notifier_list_add adds the notifier to a specific NotifierList;
> notifier_remove removes the notifier from whatever list it is in.
>
> Normally whoever implements notifiers does not have access to the
> NotifierList, so there are wrappers for both notifier_list_add and
> notifier_list_remove. This patch changes things so that the wrappers for
> notifier_remove are not needed anymore (though this series was already big
> enough, so I left the wrappers in).
I see.
Stefan
- [Qemu-devel] [PATCH 0/8] qemu-queue cleanups, Paolo Bonzini, 2012/01/02
- [Qemu-devel] [PATCH 2/8] block-migration: switch to QTAILQ, Paolo Bonzini, 2012/01/02
- [Qemu-devel] [PATCH 3/8] qed: switch to QTAILQ, Paolo Bonzini, 2012/01/02
- [Qemu-devel] [PATCH 8/8] block: use QSIMPLEQ for the AIO free list, Paolo Bonzini, 2012/01/02
- [Qemu-devel] [PATCH 7/8] coroutine: switch to QSIMPLEQ, Paolo Bonzini, 2012/01/02
- [Qemu-devel] [PATCH 5/8] qemu-queue: really simplify QSIMPLEQ, Paolo Bonzini, 2012/01/02
- [Qemu-devel] [PATCH 6/8] qemu-queue: drop QCIRCLEQ, Paolo Bonzini, 2012/01/02
- [Qemu-devel] [PATCH 4/8] ccid: switch to QTAILQ, Paolo Bonzini, 2012/01/02
- Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/8] qemu-queue cleanups, Stefan Hajnoczi, 2012/01/03