[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/6] s390: fix cpu hotplug / cpu activity on interru
From: |
Alexander Graf |
Subject: |
[Qemu-devel] [PATCH 6/6] s390: fix cpu hotplug / cpu activity on interrupts |
Date: |
Wed, 4 Jan 2012 03:13:12 +0100 |
From: Christian Borntraeger <address@hidden>
The add_del/running_cpu code and env->halted are tracking stopped cpus.
Sleeping cpus (idle and enabled for interrupts) are waiting inside the
kernel.
No interrupt besides the restart can move a cpu from stopped to
operational. This is already handled over there. So lets just remove
the bogus wakup from the common interrupt delivery, otherwise any
interrupt will wake up a cpu, even if this cpu is stopped (Thus leading
to strange hangs on sigp restart)
This fixes
echo 0 > /sys/devices/system/cpu/cpu0/online
echo 1 > /sys/devices/system/cpu/cpu0/online
in the guest
Signed-off-by: Christian Borntraeger<address@hidden>
Signed-off-by: Alexander Graf <address@hidden>
---
target-s390x/kvm.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
index 40b0ab1..b1404bf 100644
--- a/target-s390x/kvm.c
+++ b/target-s390x/kvm.c
@@ -185,9 +185,6 @@ void kvm_s390_interrupt_internal(CPUState *env, int type,
uint32_t parm,
return;
}
- s390_add_running_cpu(env);
- qemu_cpu_kick(env);
-
kvmint.type = type;
kvmint.parm = parm;
kvmint.parm64 = parm64;
--
1.6.0.2
- [Qemu-devel] [PULL 0/6] s390 patch queue 2012-01-04, Alexander Graf, 2012/01/03
- [Qemu-devel] [PATCH 2/6] Compile device-hotplug on all targets, Alexander Graf, 2012/01/03
- [Qemu-devel] [PATCH 5/6] s390x: add TR function for EXECUTE, Alexander Graf, 2012/01/03
- [Qemu-devel] [PATCH 4/6] Expose drive_add on all architectures, Alexander Graf, 2012/01/03
- [Qemu-devel] [PATCH 6/6] s390: fix cpu hotplug / cpu activity on interrupts,
Alexander Graf <=
- [Qemu-devel] [PATCH 3/6] Add generic drive hotplugging, Alexander Graf, 2012/01/03
- [Qemu-devel] [PATCH 1/6] [S390] Add hotplug support, Alexander Graf, 2012/01/03
- Re: [Qemu-devel] [PULL 0/6] s390 patch queue 2012-01-04, Aurelien Jarno, 2012/01/10