[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save_live |
Date: |
Wed, 4 Jan 2012 12:14:13 +0000 |
On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman <address@hidden> wrote:
> + /* XOR encoding */
> + xor_buf = (uint8_t *) g_malloc0(TARGET_PAGE_SIZE);
Is this an old version of the code? I remember pointing out all the
useless zeroing in a previous revision. If the next line is going to
memcpy or overwrite the entire buffer, please don't zero it first -
especially when the buffer isn't just a small struct.
Stefan
- Re: [Qemu-devel] [PATCH v5 4/9] Add host_from_stream_offset_versioned function, (continued)
[Qemu-devel] [PATCH v5 3/9] Add save_block_hdr function, Orit Wasserman, 2012/01/03
[Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save_live, Orit Wasserman, 2012/01/03
- Re: [Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save_live,
Stefan Hajnoczi <=
[Qemu-devel] [PATCH v5 9/9] Add XBRLE statistics information, Orit Wasserman, 2012/01/03
[Qemu-devel] [PATCH v5 8/9] QMP commands changes, Orit Wasserman, 2012/01/03
[Qemu-devel] [PATCH v5 6/9] Add xbrle parameters to MigrationState, Orit Wasserman, 2012/01/03