Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys

[Avi Kivity]

On 01/04/2012 09:50 PM, Peter Maydell wrote:
> On 4 January 2012 19:32, Avi Kivity <address@hidden> wrote:
> > The name 'Phys' conveys exactly the same information as 
> > 'target_phys_addr_t':
> >
> >  - it has to be a physical address (no such thing as physical data)
> >  - it has to be a target address (qemu doesn't do host physical addresses)
> >  - the fact that it's a type is implied by the naming convention
> >
> > As it's 4 characters vs. 18, and C standard compliant to boot, Phys is a
> > clear winner.  Rename all instances of target_phys_addr_t to the new name.
> > All hail Phys!
> >
> >  323 files changed, 1959 insertions(+), 1959 deletions(-)
>
> Seems like gratuitous churn to me...
>

It will generate noise, but improve readability by a little bit.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.