[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/2] ahci: add support for non-PCI based cont
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/2] ahci: add support for non-PCI based controllers |
Date: |
Thu, 05 Jan 2012 15:32:01 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111220 Thunderbird/9.0 |
Am 05.01.2012 15:26, schrieb Alexander Graf:
>
> On 05.01.2012, at 15:16, Andreas Färber wrote:
>
>> Am 05.01.2012 14:52, schrieb Mark Langsdorf:
>>> From: Rob Herring <address@hidden>
>>>
>>> Add support for ahci on sysbus.
>>>
>>> Signed-off-by: Rob Herring <address@hidden>
>>> Signed-off-by: Mark Langsdorf <address@hidden>
>>> ---
>>> Changes from v1, v2
>>> Corrected indentation of PlatAHCIState members
>>> Made plat_ahci_info into a single structure, not a list
>>>
>>> hw/ide/ahci.c | 31 +++++++++++++++++++++++++++++++
>>> 1 files changed, 31 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
>>> index 135d0ee..f052e55 100644
>>> --- a/hw/ide/ahci.c
>>> +++ b/hw/ide/ahci.c
>>> @@ -25,6 +25,7 @@
>>> #include <hw/msi.h>
>>> #include <hw/pc.h>
>>> #include <hw/pci.h>
>>> +#include <hw/sysbus.h>
>>>
>>> #include "monitor.h"
>>> #include "dma.h"
>>> @@ -1214,3 +1215,33 @@ void ahci_reset(void *opaque)
>>> ahci_reset_port(s, i);
>>> }
>>> }
>>> +
>>> +typedef struct PlatAHCIState {
>>> + SysBusDevice busdev;
>>> + AHCIState ahci;
>>> +} PlatAHCIState;
>>> +
>>> +static int plat_ahci_init(SysBusDevice *dev)
>>> +{
>>> + PlatAHCIState *s = FROM_SYSBUS(PlatAHCIState, dev);
>>> + ahci_init(&s->ahci, &dev->qdev, 1);
>>> +
>>> + sysbus_init_mmio(dev, &s->ahci.mem);
>>> + sysbus_init_irq(dev, &s->ahci.irq);
>
> It's still unclear to me how you connect an irq line on the command line. How
> do you instantiate this device?
I thought, with qdev that's not possible at all.
>>> +
>>> + qemu_register_reset(ahci_reset, &s->ahci);
>>> + return 0;
>>> +}
>>> +
>>> +static SysBusDeviceInfo plat_ahci_info = {
>>> + .qdev.name = "plat-ahci",
>>
>> The commit message does not given an indication where "plat" comes from
>> - is that an ARM device name?
>
> "plat" here means "platform device". I'm not sure I like the naming though.
> Basically it's a sysbus version of AHCI, similar to how virtio-mmio is a
> sysbus version of virtio.
>
> How about "sysbus-ahci"?
Yeah, sounds better to me.
> However the question still stands: Have you verified this code works?
I believe that one's addressed to Mark. ;)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH v3 1/2] ahci: convert ahci_reset to use AHCIState, Mark Langsdorf, 2012/01/05
- [Qemu-devel] [PATCH v3 2/2] ahci: add support for non-PCI based controllers, Mark Langsdorf, 2012/01/05
- Re: [Qemu-devel] [PATCH v3 2/2] ahci: add support for non-PCI based controllers, Andreas Färber, 2012/01/05
- Re: [Qemu-devel] [PATCH v3 2/2] ahci: add support for non-PCI based controllers, Alexander Graf, 2012/01/05
- Re: [Qemu-devel] [PATCH v3 2/2] ahci: add support for non-PCI based controllers,
Andreas Färber <=
- Re: [Qemu-devel] [PATCH v3 2/2] ahci: add support for non-PCI based controllers, Mark Langsdorf, 2012/01/05
- Re: [Qemu-devel] [PATCH v3 2/2] ahci: add support for non-PCI based controllers, Rob Herring, 2012/01/05
- Re: [Qemu-devel] [PATCH v3 2/2] ahci: add support for non-PCI based controllers, Alexander Graf, 2012/01/05
- Re: [Qemu-devel] [PATCH v3 2/2] ahci: add support for non-PCI based controllers, Peter Maydell, 2012/01/05
- Re: [Qemu-devel] [PATCH v3 2/2] ahci: add support for non-PCI based controllers, Mark Langsdorf, 2012/01/05
- Re: [Qemu-devel] [PATCH v3 2/2] ahci: add support for non-PCI based controllers, Rob Herring, 2012/01/05
Re: [Qemu-devel] [PATCH v3 1/2] ahci: convert ahci_reset to use AHCIState, Andreas Färber, 2012/01/05
Re: [Qemu-devel] [PATCH v3 1/2] ahci: convert ahci_reset to use AHCIState, Alexander Graf, 2012/01/05