[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 7/9] net/socket.c: Fix fd leak in net_socket_listen_
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 7/9] net/socket.c: Fix fd leak in net_socket_listen_init() error paths |
Date: |
Fri, 6 Jan 2012 15:51:26 +0000 |
From: Peter Maydell <address@hidden>
Fix a leak of a file descriptor due to missing closesocket() calls
in error paths in net_socket_listen_init().
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
net/socket.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/net/socket.c b/net/socket.c
index aaf9be4..c9d70d3 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -427,12 +427,14 @@ static int net_socket_listen_init(VLANState *vlan,
if (ret < 0) {
perror("bind");
g_free(s);
+ closesocket(fd);
return -1;
}
ret = listen(fd, 0);
if (ret < 0) {
perror("listen");
g_free(s);
+ closesocket(fd);
return -1;
}
s->vlan = vlan;
--
1.7.7.3
- [Qemu-devel] [PULL 0/9] Trivial patches for 20 December 2011 to 6 January 2012, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH 5/9] configure: Fix test for supported host CPU type, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH 3/9] scsi virtio-blk usb-msd: Clean up device init error messages, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH 7/9] net/socket.c: Fix fd leak in net_socket_listen_init() error paths,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 2/9] Strip trailing '\n' from error_report()'s first argument (again), Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH 8/9] Make python mandatory, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH 6/9] gdbstub: Fix fd leak in gdbserver_open() error path, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH 1/9] qemu-options.hx: fix tls-channel help text, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH 4/9] configure: CONFIG_QEMU_INTERP_PREFIX only for user mode, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH 9/9] qemu-nbd: drop loop which can never loop, Stefan Hajnoczi, 2012/01/06
- Re: [Qemu-devel] [PULL 0/9] Trivial patches for 20 December 2011 to 6 January 2012, Anthony Liguori, 2012/01/09