Re: [Qemu-devel] [PATCH 26/30] grackle: remove broken pci device

[Andreas Färber]

Am 08.01.2012 02:46, schrieb Aurelien Jarno:
> On Mon, Jan 02, 2012 at 06:52:15PM -0600, Anthony Liguori wrote:
>> I have no idea what's going on here, but this is broken and cannot possibly
>> work because:
>>
>>  1) It's qdev name conflicts with a device that sits on SysBus
>>
>>  2) The PCI constructor expects a SysBus device... but's it's a PCIDevice
>>
>> If you do qdev_create("grackle"), the code expects to get the SysBus version
>> so drop the mystery PCI version.
>>
>> Signed-off-by: Anthony Liguori <address@hidden>
>> ---
>>  hw/grackle_pci.c |   17 -----------------
>>  1 files changed, 0 insertions(+), 17 deletions(-)
> 
> NACK. Maybe the current code is not correct, but it actually works, and
> a PCI host device like this one is definitely needed on the system.
> 
> Trying to apply this patch, qemu-system-ppc fails to start with:
> 
>   qemu: hardware error: Unknown device 'grackle' for bus 'PCI'

Similar for uni-north and qemu-system-ppc64 or -M mac99 (cf. v1).

Now that PReP is somewhat restored on my branch, if Anthony wants, I can
send patches to resolve the name conflicts next week.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg